Reorder code in entity layer to have consistent order of properties. #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @shunter!
Reviewers, don't forget to make sure that:
|
shunter
force-pushed
the
entityCleanup
branch
4 times, most recently
from
9354248 to
2b4d9b3
Compare
|
Merge conflict on |
shunter
force-pushed
the
entityCleanup
branch
2 times, most recently
from
2484709 to
5f75445
Compare
Previously the list of properties for each type of Graphics in the entity layer was different everywhere. This made it quite difficult to compare the set of properties in the code vs the set of properties in CZML. I went through and reordered all these locations to have properties in the same order in each. * The documentation for the constructor for each graphics type * The content of the constructor (initializing `_property` and `_propertySubscription` to `undefined`) * The public get/set properties * The contents of the `clone` function for each graphics type * The contents of the `merge` function for each graphics type * The code assigning the values of properties in `CzmlDataSource`. Also add some missing functionality to `CzmlDataSource`: `box.heightReference` `cylinder.heightReference` `ellipsoid.heightReference` `corridor.classificationType` `ellipse.classificationType` `polygon.classificationType` `polyline.classificationType` `rectangle.classificationType`
emackey
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the list of properties for each type of Graphics in the entity layer was different everywhere. This made it quite difficult to compare the set of properties in the code vs the set of properties in CZML. I went through and reordered all these locations to have properties in the same order in each.
_propertyand_propertySubscriptiontoundefined)clonefunction for each graphics typemergefunction for each graphics typeCzmlDataSource.Also add some missing functionality to
CzmlDataSource:box.heightReferencecylinder.heightReferenceellipsoid.heightReferencecorridor.classificationTypeellipse.classificationTypepolygon.classificationTypepolyline.classificationTyperectangle.classificationType